[IOPID-1714] handle malformed response on iOS #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-1714 |
|
🎉 All dependencies have been resolved ! |
shadowsheep1
added a commit
to pagopa/io-app
that referenced
this pull request
Apr 4, 2024
## Short description > [!Warning] > This PR depends on pagopa/io-cie-sdk#51 > [!Important] > The misleading copy on the error page under the NFC Session Manager is not a subject of this PR. > [!Tip] > Translations ✅ This PR update the `io-cie-sdk` library to handle malformed responses to avoid crashes on iOS devices in those use cases. <details><summary>demo</summary> <p> | Generic error on iOS NFC Session Manager Alert | | - | | <video src="https://github.com/pagopa/io-app/assets/16268789/22d3ba0b-d1a4-46c9-aeaf-9eac1f7cdd5c" /> | </p> </details> ## List of changes proposed in this pull request - Fix UI regression in `LoadingSpinnerOverlay`. - Add a generic error message in case of malformed URLs. ## How to test Run the app in production with a real iOS device and try to login with EIC several times. No crash'd happen. --------- Co-authored-by: mariateresaventura <90319761+mariateresaventura@users.noreply.github.com> Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR depends on pagopa/io-cie-ios-sdk#10
This PR handle malformed responses to avoid crashes on iOS devices in those use cases.
List of changes