Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add is_email_validated and is_email_already_taken in ProfileAttr #328

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Nov 30, 2023

Short description

This PR allows the configuration of is_email_validated and is_email_already_taken with config.json.

How to test

Try to set config.json as below:

{
  "profile": {
    "attrs": {
      "name": "Gian Maria",
      "is_email_validated": false,
      "is_email_already_taken": true
    }
  }
}

and login. The profile you got during the login phase comes with the corresponding values of is_email_validated and is_email_already_taken.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #328 (e795a59) into master (1526794) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 25.00%.

❗ Current head e795a59 differs from pull request most recent head a6997c2. Consider uploading reports for the commit a6997c2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   67.99%   68.00%           
=======================================
  Files         149      149           
  Lines        5112     5113    +1     
  Branches      599      599           
=======================================
+ Hits         3476     3477    +1     
  Misses       1635     1635           
  Partials        1        1           
Files Coverage Δ
src/payloads/profile.ts 78.57% <ø> (ø)
src/routers/features/idpay/barcode.ts 50.00% <100.00%> (+2.94%) ⬆️
src/types/config.ts 100.00% <ø> (ø)
src/persistence/idpay.ts 72.28% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01edea...a6997c2. Read the comment docs.

@shadowsheep1 shadowsheep1 self-assigned this Dec 1, 2023
@shadowsheep1 shadowsheep1 requested a review from Ladirico December 1, 2023 13:08
@shadowsheep1 shadowsheep1 marked this pull request as ready for review December 1, 2023 13:09
@shadowsheep1 shadowsheep1 requested a review from a team as a code owner December 1, 2023 13:09
@Ladirico
Copy link
Contributor

Ladirico commented Dec 4, 2023

LGTM!

@Ladirico Ladirico merged commit aa8c414 into master Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants