Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIW-951] Refactor user wallet endpoints for payments feature #358

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

mastro993
Copy link
Contributor

Short description

This PR refactors the user method's wallet in order to display more data on the IO app

How to test

Tests should solve correctly

@mastro993 mastro993 requested a review from a team as a code owner March 27, 2024 12:02
@mastro993 mastro993 changed the title [SIM-951] User methods wallet refactoring [SIW-951] User methods wallet refactoring Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.46%. Comparing base (abeffb2) to head (5802a2d).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   70.38%   70.46%   +0.08%     
==========================================
  Files         141      142       +1     
  Lines        4656     4669      +13     
  Branches      565      570       +5     
==========================================
+ Hits         3277     3290      +13     
  Misses       1308     1308              
  Partials       71       71              
Files Coverage Δ
src/features/wallet/payloads/paymentMethods.ts 100.00% <100.00%> (ø)
src/features/wallet/persistence/paymentMethods.ts 100.00% <100.00%> (ø)
src/features/wallet/routers/payment.ts 37.33% <ø> (+0.62%) ⬆️
src/features/wallet/routers/wallets.ts 33.33% <0.00%> (ø)
src/features/wallet/persistence/userWallet.ts 66.66% <81.25%> (-1.91%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c7fa0...5802a2d. Read the comment docs.

@mastro993 mastro993 changed the title [SIW-951] User methods wallet refactoring [SIW-951] Refactor payments user wallet endpoints Mar 27, 2024
@mastro993 mastro993 changed the title [SIW-951] Refactor payments user wallet endpoints [SIW-951] Refactor user wallet endpoints for 'payments' feature Mar 27, 2024
@mastro993 mastro993 changed the title [SIW-951] Refactor user wallet endpoints for 'payments' feature [SIW-951] Refactor user wallet endpoints for payments feature Mar 27, 2024
Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 merged commit 7833940 into master Apr 4, 2024
8 checks passed
mastro993 added a commit to pagopa/io-app that referenced this pull request Apr 4, 2024
…ction (#5639)

> [!WARNING]
> This PR depends on #5626 and
pagopa/io-dev-api-server#358


## Short description
This PR adds the user's payment methods in the new wallet section

## List of changes proposed in this pull request
- Added store and saga for the payments' `wallet` feature
- Added card mapping for payment methods
- Fixed a glitch in the ID Pay cards in wallet

## How to test
With the `io-dev-api-server`, make sure to checkout this branch:
pagopa/io-dev-api-server#358
From the **Profile** section, enable the **New wallet section** FF.
You should be able to see payment cards in the wallet.

## Preview
<img
src="https://github.com/pagopa/io-app/assets/6160324/361f1808-48f9-425d-84d3-ef0ac7b6d62a"
width="200" />

---------

Co-authored-by: Jacopo Pompilii <Jacopo.pompilii@pagopa.it>
Co-authored-by: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com>
@Vangaorth Vangaorth deleted the SIW-951-add-payment-methods-in-new-wallet-section branch February 13, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants