chore: [IOBP-697] Add payments section definitions #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
========================================
Coverage 64.34% 64.34%
========================================
Files 167 167
Lines 5354 5354
Branches 748 726 -22
========================================
Hits 3445 3445
- Misses 1769 1908 +139
+ Partials 140 1 -139
... and 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
🎉 All dependencies have been resolved ! |
Hantex9
added a commit
to pagopa/io-app
that referenced
this pull request
Jun 19, 2024
##⚠️ This PR depends on pagopa/io-services-metadata#787⚠️ ## Short description This PR adds the ability to display a remote alert (formally called a banner) within the home payment screen. ## List of changes proposed in this pull request - Created a new `PaymentsAlertStatus` component that takes the `payments` section status to show/hide a banner; - Updated io_content_specs definitions into package.json -> WARNING: As soon as the pagopa/io-services-metadata#787 PR is merged, the content definition reference will have the 1.0.33 version - Created a utility function `getAlertVariant` in order to "normalize" the alert variant based on the SectionStatus LevelEnum; ## How to test - Checkout this PR from the dev-server: pagopa/io-dev-api-server#389 - Run `yarn generate` both on the dev-server and the app - Editing the `payments` attribute from the `backend.ts` file on the dev-server, you should be able to see or not see the alert. ## Preview |Fade In|Fade Out| |-|-| |<video src="https://github.com/pagopa/io-app/assets/34343582/0c9506c3-da87-4087-bbaa-a29b16d8d822" />|<video src="https://github.com/pagopa/io-app/assets/34343582/6f7281d0-2d29-4653-883b-30548ffce959" />
Ladirico
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the "payments" section from the statuses to show/hide the alert (formally called banner) service in the payments home.
List of changes proposed in this pull request
backend.tsfile