chore: [IOBP-909] Adapt IDPay definitions mock API #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hevelius
requested changes
Oct 4, 2024
hevelius
approved these changes
Oct 4, 2024
hevelius
reviewed
Oct 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
========================================
Coverage 64.40% 64.40%
========================================
Files 167 167
Lines 5330 5330
Branches 725 718 -7
========================================
Hits 3433 3433
- Misses 1759 1896 +137
+ Partials 138 1 -137
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hantex9
added a commit
to pagopa/io-app
that referenced
this pull request
Oct 4, 2024
## Short description This PR fixes the timeline amount format considering the amount as cents ## List of changes proposed in this pull request - Used the `formatNumberCentsToAmount` function inside the `formatAbsNumberAmountCentsOrDefault` to format the amount from cents into correct string. ## How to test - The related unit tests should pass correctly - Checkout the dev-server with this PR: pagopa/io-dev-api-server#416 - After that enable IDPay feature flag from the profile settings - With the dev-server started you should be able to see into "Portafoglio" section two mocked initiatives --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
LazyAfternoons
pushed a commit
to pagopa/io-app
that referenced
this pull request
Oct 8, 2024
## Short description This PR fixes the timeline amount format considering the amount as cents ## List of changes proposed in this pull request - Used the `formatNumberCentsToAmount` function inside the `formatAbsNumberAmountCentsOrDefault` to format the amount from cents into correct string. ## How to test - The related unit tests should pass correctly - Checkout the dev-server with this PR: pagopa/io-dev-api-server#416 - After that enable IDPay feature flag from the profile settings - With the dev-server started you should be able to see into "Portafoglio" section two mocked initiatives --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adapts the IDPay definitions API mock with the new openAPI
List of changes proposed in this pull request