Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPID-2359] remove remote FF session refresh #425

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented Oct 21, 2024

Warning

This PR depends on pagopa/io-services-metadata#847

Short description

Delete remote session refresh FF

How to test

Run the application using local environment and iand using proxyman or any tool that can intercept the fetch calls made by the app you'll see that in this one here: http://proxyman.local:3000/static_contents/status/backend.json?ms=* the value sessionRefresh is not entered (as you can see from the screen)

response without sessionRefresh

@Ladirico Ladirico self-assigned this Oct 21, 2024
@Ladirico Ladirico requested a review from a team as a code owner October 21, 2024 12:26
@Ladirico Ladirico added the IO-A&I IO - Autenticazione e Identità label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (65c0c14) to head (695fb12).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   64.28%   64.28%           
=======================================
  Files         167      167           
  Lines        5362     5362           
  Branches      754      754           
=======================================
  Hits         3447     3447           
  Misses       1775     1775           
  Partials      140      140           
Files with missing lines Coverage Δ
src/payloads/backend.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ee888...695fb12. Read the comment docs.

Copy link

dpulls bot commented Oct 28, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ladirico Ladirico merged commit efd21f2 into master Oct 28, 2024
8 checks passed
@Ladirico Ladirico deleted the IOPID-2359-remove-remote-ff-session-refresh branch October 28, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants