Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPID-2322] - CieID errors #426

Merged
merged 6 commits into from
Oct 30, 2024
Merged

[IOPID-2322] - CieID errors #426

merged 6 commits into from
Oct 30, 2024

Conversation

ChrisMattew
Copy link
Collaborator

List of changes proposed in this pull request

  • Fixed 404 on error.html redirects
  • Added CIEID_OPERATION_CANCEL spid error
  • Added 2 new Buttons to simulate CieID error messages coming from Deep Links

Screen

new dev server

@ChrisMattew ChrisMattew requested a review from a team as a code owner October 22, 2024 14:19
@ChrisMattew ChrisMattew self-assigned this Oct 22, 2024
@ChrisMattew ChrisMattew added the IO-A&I IO - Autenticazione e Identità label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (695fb12) to head (a64bf42).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/routers/public.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   64.28%   64.28%   -0.01%     
==========================================
  Files         167      167              
  Lines        5362     5364       +2     
  Branches      754      731      -23     
==========================================
+ Hits         3447     3448       +1     
- Misses       1775     1915     +140     
+ Partials      140        1     -139     
Files with missing lines Coverage Δ
src/routers/public.ts 67.64% <50.00%> (-0.27%) ⬇️

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd21f2...a64bf42. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ladirico Ladirico merged commit 1323b3b into master Oct 30, 2024
8 checks passed
@Ladirico Ladirico deleted the IOPID-2322-cie-id-errors branch October 30, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants