Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-1885] Autogenerated FIMS authentication specs #431

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR adds the autogeneration of FIMS authentication specs.

List of changes proposed in this pull request

  • Automatica generation of FIMS authentication specs
  • latest version of codegen to support redirects as successful responses
  • Proper coding of both successful and failure responses from the first part of the authentication flow

How to test

Check that both success and failure flows do not generate any kind of server runtime error.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 7.04225% with 66 lines in your changes missing coverage. Please review.

Project coverage is 64.15%. Comparing base (a64bf42) to head (39efa9c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/features/fims/routers/providerRouter.ts 5.79% 65 Missing ⚠️
src/features/fims/services/providerService.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   64.28%   64.15%   -0.13%     
==========================================
  Files         167      167              
  Lines        5364     5387      +23     
  Branches      731      741      +10     
==========================================
+ Hits         3448     3456       +8     
- Misses       1915     1930      +15     
  Partials        1        1              
Files with missing lines Coverage Δ
src/features/fims/services/providerService.ts 41.17% <50.00%> (+3.67%) ⬆️
src/features/fims/routers/providerRouter.ts 8.22% <5.79%> (+0.98%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69fe64...39efa9c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant