[#Ente-143] Add FiscalCode inside Jira Ticket

.env.demo

@@ -52,4 +52,5 @@ JIRA_TRANSITION_UPDATED_ID=11
 
 JIRA_DELEGATE_ID_FIELD=customfield_xxxxx
 JIRA_EMAIL_ID_FIELD=customfield_xxxxx
+JIRA_ORGANIZATION_FISCALCODE=customfield_xxxxx
 JIRA_ORGANIZATION_ID_FIELD=customfield_xxxxx

.gitignore

@@ -16,5 +16,6 @@ coverage
 src/**/*.js
 .env
 .vscode
+generated
 generated/api/*
 build

src/__tests__/jira-client.test.ts

@@ -1,4 +1,8 @@
-import { EmailString, NonEmptyString } from "italia-ts-commons/lib/strings";
+import {
+  EmailString,
+  NonEmptyString,
+  OrganizationFiscalCode
+} from "italia-ts-commons/lib/strings";
 import { ServiceId } from "../../generated/api/ServiceId";
 import * as config from "../config";
 import { JiraAPIClient } from "../jira_client";
@@ -8,6 +12,7 @@ const JIRA_CONFIG = {
   JIRA_DELEGATE_ID_FIELD: "",
   JIRA_EMAIL_ID_FIELD: "",
   JIRA_NAMESPACE_URL: "board.atlassian.com",
+  JIRA_ORGANIZATION_FISCALCODE_ID_FIELD: "",
   JIRA_ORGANIZATION_ID_FIELD: "",
   JIRA_STATUS_COMPLETE: "COMPLETE",
   JIRA_STATUS_IN_PROGRESS: "REVIEW",
@@ -73,6 +78,8 @@ describe("JiraAPIClient#createJiraIssue", () => {
         delegateIdField: JIRA_CONFIG.JIRA_DELEGATE_ID_FIELD,
         emailIdField: JIRA_CONFIG.JIRA_EMAIL_ID_FIELD,
         jiraEmail: JIRA_CONFIG.JIRA_USERNAME,
+        organizationFiscalCodeIdField:
+          JIRA_CONFIG.JIRA_ORGANIZATION_FISCALCODE_ID_FIELD,
         organizationIdField: JIRA_CONFIG.JIRA_ORGANIZATION_ID_FIELD,
         statusComplete: JIRA_CONFIG.JIRA_STATUS_COMPLETE,
         token: JIRA_CONFIG.JIRA_TOKEN
@@ -86,6 +93,7 @@ describe("JiraAPIClient#createJiraIssue", () => {
         {
           delegateName: "firstName lastName" as NonEmptyString,
           email: "test@email.com" as EmailString,
+          organizationFiscalCode: "00000000000" as OrganizationFiscalCode,
           organizationName: "MyOrganizationName" as NonEmptyString,
           serviceId: (ServiceId as unknown) as NonEmptyString
         },
@@ -117,6 +125,8 @@ describe("JiraAPIClient#search and apply transition", () => {
         delegateIdField: JIRA_CONFIG.JIRA_DELEGATE_ID_FIELD,
         emailIdField: JIRA_CONFIG.JIRA_EMAIL_ID_FIELD,
         jiraEmail: JIRA_CONFIG.JIRA_USERNAME,
+        organizationFiscalCodeIdField:
+          JIRA_CONFIG.JIRA_ORGANIZATION_FISCALCODE_ID_FIELD,
         organizationIdField: JIRA_CONFIG.JIRA_ORGANIZATION_ID_FIELD,
         statusComplete: JIRA_CONFIG.JIRA_STATUS_COMPLETE,
         token: JIRA_CONFIG.JIRA_TOKEN
@@ -149,6 +159,8 @@ describe("JiraAPIClient#search and apply transition", () => {
         delegateIdField: JIRA_CONFIG.JIRA_DELEGATE_ID_FIELD,
         emailIdField: JIRA_CONFIG.JIRA_EMAIL_ID_FIELD,
         jiraEmail: JIRA_CONFIG.JIRA_USERNAME,
+        organizationFiscalCodeIdField:
+          JIRA_CONFIG.JIRA_ORGANIZATION_FISCALCODE_ID_FIELD,
         organizationIdField: JIRA_CONFIG.JIRA_ORGANIZATION_ID_FIELD,
         statusComplete: JIRA_CONFIG.JIRA_STATUS_COMPLETE,
         token: JIRA_CONFIG.JIRA_TOKEN
@@ -179,6 +191,8 @@ describe("JiraAPIClient#search and apply transition", () => {
         delegateIdField: JIRA_CONFIG.JIRA_DELEGATE_ID_FIELD,
         emailIdField: JIRA_CONFIG.JIRA_EMAIL_ID_FIELD,
         jiraEmail: JIRA_CONFIG.JIRA_USERNAME,
+        organizationFiscalCodeIdField:
+          JIRA_CONFIG.JIRA_ORGANIZATION_FISCALCODE_ID_FIELD,
         organizationIdField: JIRA_CONFIG.JIRA_ORGANIZATION_ID_FIELD,
         statusComplete: JIRA_CONFIG.JIRA_STATUS_COMPLETE,
         token: JIRA_CONFIG.JIRA_TOKEN

src/config.ts

@@ -120,6 +120,7 @@ export const IJIRA_CONFIG = t.interface({
   JIRA_DELEGATE_ID_FIELD: NonEmptyString,
   JIRA_EMAIL_ID_FIELD: NonEmptyString,
   JIRA_NAMESPACE_URL: NonEmptyString,
+  JIRA_ORGANIZATION_FISCALCODE_ID_FIELD: NonEmptyString,
   JIRA_ORGANIZATION_ID_FIELD: NonEmptyString,
   JIRA_STATUS_COMPLETE: NonEmptyString,
   JIRA_STATUS_IN_PROGRESS: NonEmptyString,
@@ -142,6 +143,9 @@ export const getJiraConfigOrThrow = () =>
     JIRA_EMAIL_ID_FIELD: fromNullable(
       process.env.JIRA_EMAIL_ID_FIELD
     ).getOrElse(""),
+    JIRA_ORGANIZATION_FISCALCODE_ID_FIELD: fromNullable(
+      process.env.JIRA_ORGANIZATION_FISCALCODE_ID_FIELD
+    ).getOrElse(""),
     JIRA_ORGANIZATION_ID_FIELD: fromNullable(
       process.env.JIRA_ORGANIZATION_ID_FIELD
     ).getOrElse(""),

src/controllers/services.ts

@@ -442,6 +442,8 @@ export async function newDisableRequest(
           {
             delegateName: `${authenticatedUser.given_name} ${authenticatedUser.family_name}` as NonEmptyString,
             email: authenticatedUser.emails[0],
+            organizationFiscalCode:
+              errorOrService.value.organization_fiscal_code,
             organizationName: errorOrService.value.organization_name,
             serviceId
           },
@@ -612,6 +614,8 @@ export async function newReviewRequest(
               {
                 delegateName: `${authenticatedUser.given_name} ${authenticatedUser.family_name}` as NonEmptyString,
                 email: authenticatedUser.emails[0],
+                organizationFiscalCode:
+                  errorOrService.value.organization_fiscal_code,
                 organizationName: errorOrService.value.organization_name,
                 serviceId
               }

src/jira_client.ts

@@ -1,3 +1,4 @@
+import { OrganizationFiscalCode } from "@pagopa/ts-commons/lib/strings";
 import { toError } from "fp-ts/lib/Either";
 import { fromNullable } from "fp-ts/lib/Option";
 import {
@@ -18,6 +19,7 @@ export interface IJiraConfig {
   readonly boardId: NonEmptyString;
   readonly delegateIdField: NonEmptyString;
   readonly emailIdField: NonEmptyString;
+  readonly organizationFiscalCodeIdField: NonEmptyString;
   readonly organizationIdField: NonEmptyString;
   readonly jiraEmail: EmailAddress;
   readonly statusComplete: NonEmptyString;
@@ -91,6 +93,7 @@ export interface IJiraAPIClient {
     serviceData: {
       readonly delegateName: NonEmptyString;
       readonly email: EmailString;
+      readonly organizationFiscalCode: OrganizationFiscalCode;
       readonly organizationName: NonEmptyString;
       readonly serviceId: NonEmptyString;
     },
@@ -164,6 +167,7 @@ export function JiraAPIClient(
     serviceData: {
       readonly delegateName: NonEmptyString;
       readonly email: EmailString;
+      readonly organizationFiscalCode: OrganizationFiscalCode;
       readonly organizationName: NonEmptyString;
       readonly serviceId: NonEmptyString;
     },
@@ -180,6 +184,7 @@ export function JiraAPIClient(
               },
               [`${config.delegateIdField}`]: `${serviceData.delegateName}`,
               [`${config.emailIdField}`]: `${serviceData.email}`,
+              [`${config.organizationFiscalCodeIdField}`]: `${serviceData.organizationFiscalCode}`,
               [`${config.organizationIdField}`]: `${serviceData.organizationName}`,
               labels: [
                 `${JIRA_SERVICE_TAG_PREFIX}${serviceData.serviceId}`

src/middlewares/api_client.ts

@@ -49,6 +49,8 @@ export function getJiraClientMiddleware(
         delegateIdField: jiraConfig.JIRA_DELEGATE_ID_FIELD,
         emailIdField: jiraConfig.JIRA_EMAIL_ID_FIELD,
         jiraEmail: jiraConfig.JIRA_USERNAME,
+        organizationFiscalCodeIdField:
+          jiraConfig.JIRA_ORGANIZATION_FISCALCODE_ID_FIELD,
         organizationIdField: jiraConfig.JIRA_ORGANIZATION_ID_FIELD,
         statusComplete: jiraConfig.JIRA_STATUS_COMPLETE,
         token: jiraConfig.JIRA_TOKEN

tsconfig.json

@@ -11,13 +11,14 @@
     "noFallthroughCasesInSwitch": true,
     "resolveJsonModule": true,
     "sourceMap": true,
-    "outDir": "build"
+    "outDir": "build",
+    "skipLibCheck": true
   },
   "include": [
     "src/**/*",
     "package.json"
   ],
   "exclude": [
-    "node_modules"
+    "node_modules",
   ]
 }