Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-358] enrich lollipop_definitions.yaml #334

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#IOPID-358] enrich lollipop_definitions.yaml #334

wants to merge 2 commits into from

Conversation

arcogabbo
Copy link
Contributor

@arcogabbo arcogabbo commented Jun 23, 2023 •
edited
Loading

List of Changes

  • added utility headers/schemas to lollipop_definitions

Motivation and Context

unify all lollipop spec utilities in one place

How Has This Been Tested?

the file is compliant to the OpenAPI 3 spec
our internal codegen successfully generates the types as intended

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@arcogabbo arcogabbo requested a review from a team as a code owner June 23, 2023 07:37
@arcogabbo arcogabbo changed the title enriched lollipop_definitions.yaml enrich lollipop_definitions.yaml Jun 23, 2023
@github-actions
Copy link

github-actions bot commented Jun 23, 2023 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-358

@arcogabbo arcogabbo changed the title enrich lollipop_definitions.yaml [#IOPID-358] enrich lollipop_definitions.yaml Jun 23, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldisaro michaeldisaro Awaiting requested review from michaeldisaro michaeldisaro is a code owner automatically assigned from pagopa/io-backend-contributors

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner automatically assigned from pagopa/io-backend-contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arcogabbo