add track event when createorupdateinstallation ends

pagopa · Jun 20, 2024 · 694c560 · 694c560
1 parent 9a5c94f
commit 694c560
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 8 deletions.
diff --git a/HandleNHCreateOrUpdateInstallationCallActivity/__tests__/handler.test.ts b/HandleNHCreateOrUpdateInstallationCallActivity/__tests__/handler.test.ts
@@ -15,6 +15,7 @@ import { NotificationHubConfig } from "../../utils/notificationhubServicePartiti
 import { envConfig } from "../../__mocks__/env-config.mock";
 import { createActivity } from "../../utils/durable/activities";
 import { NotificationHubsClient } from "@azure/notification-hubs";
+import { TelemetryClient } from "applicationinsights";
 
 const activityName = "any";
 
@@ -48,11 +49,15 @@ const mockBuildNHClient = jest
     _ => (mockNotificationHubService as unknown) as NotificationHubsClient
   );
 
+const mockTelemetryClient = ({
+  trackEvent: jest.fn(() => {})
+} as unknown) as TelemetryClient;
+
 const handler = createActivity(
   activityName,
   ActivityInput, // FIXME: the editor marks it as type error, but tests compile correctly
   ActivityResultSuccess,
-  getActivityBody(mockBuildNHClient)
+  getActivityBody(mockBuildNHClient, mockTelemetryClient)
 );
 
 describe("HandleNHCreateOrUpdateInstallationCallActivity", () => {

diff --git a/HandleNHCreateOrUpdateInstallationCallActivity/handler.ts b/HandleNHCreateOrUpdateInstallationCallActivity/handler.ts
@@ -2,6 +2,7 @@ import { pipe } from "fp-ts/lib/function";
 import * as TE from "fp-ts/lib/TaskEither";
 import * as t from "io-ts";
 import { NotificationHubsClient } from "@azure/notification-hubs";
+import { TelemetryClient } from "applicationinsights";
 import { toString } from "../utils/conversions";
 
 import { InstallationId } from "../generated/notifications/InstallationId";
@@ -36,7 +37,8 @@ const getPlatformFromPlatformEnum = (
 ): "apns" | "fcmv1" => (platformEnum === "apns" ? "apns" : "fcmv1");
 
 export const getActivityBody = (
-  buildNHClient: (nhConfig: NotificationHubConfig) => NotificationHubsClient
+  buildNHClient: (nhConfig: NotificationHubConfig) => NotificationHubsClient,
+  telemetryClient: TelemetryClient
   // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 ): ActivityBodyImpl => ({ input, logger }) => {
   logger.info(`INSTALLATION_ID=${input.installationId}`);
@@ -50,8 +52,33 @@ export const getActivityBody = (
       input.tags
     ),
     TE.bimap(
-      e => retryActivity(logger, toString(e)),
-      () => ActivityResultSuccess.encode({ kind: "SUCCESS" })
+      e => {
+        telemetryClient.trackEvent({
+          name: "api.messages.notification.createOrUpdateInstallation.failure",
+          properties: {
+            installationId: input.installationId,
+            isSuccess: "false",
+            notificationHubName: input.notificationHubConfig.AZURE_NH_HUB_NAME,
+            platform: input.platform,
+            reason: e.message
+          },
+          tagOverrides: { samplingEnabled: "false" }
+        });
+        return retryActivity(logger, toString(e));
+      },
+      () => {
+        telemetryClient.trackEvent({
+          name: "api.messages.notification.createOrUpdateInstallation.success",
+          properties: {
+            installationId: input.installationId,
+            isSuccess: "true",
+            notificationHubName: input.notificationHubConfig.AZURE_NH_HUB_NAME,
+            platform: input.platform
+          },
+          tagOverrides: { samplingEnabled: "false" }
+        });
+        return ActivityResultSuccess.encode({ kind: "SUCCESS" });
+      }
     )
   );
 };
diff --git a/HandleNHCreateOrUpdateInstallationCallActivity/index.ts b/HandleNHCreateOrUpdateInstallationCallActivity/index.ts
@@ -1,4 +1,6 @@
 import { RetryOptions } from "durable-functions";
+import { initTelemetryClient } from "../utils/appinsights";
+import { getConfigOrThrow } from "../utils/config";
 
 import { createActivity } from "../utils/durable/activities";
 import * as o from "../utils/durable/orchestrators";
@@ -13,6 +15,10 @@ export { ActivityInput, ActivityResultSuccess } from "./handler";
 
 export const activityName = "HandleNHCreateOrUpdateInstallationCallActivity";
 
+const config = getConfigOrThrow();
+
+const telemetryClient = initTelemetryClient(config);
+
 /**
  * Build a `CreateOrUpdateActivity` to be called by an Orchestrator
  *
@@ -32,7 +38,7 @@ const activityFunctionHandler = createActivity(
   activityName,
   ActivityInput,
   ActivityResultSuccess,
-  getActivityBody(buildNHClient)
+  getActivityBody(buildNHClient, telemetryClient)
 );
 
 export default activityFunctionHandler;
diff --git a/utils/notification.ts b/utils/notification.ts
@@ -87,9 +87,7 @@ export const getInstallationFromInstallationId = (
         E.mapLeft(
           () =>
             new Error(
-              `Error while retrieving the installation with installationId: ${installationId} | ${JSON.stringify(
-                error
-              )}`
+              `Error while retrieving the installation with installationId: ${installationId}`
             )
         ),
         E.map(() => O.none),