Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#Ip-342] Upgrade fp-ts #36

Merged
merged 30 commits into from
Sep 21, 2021
Merged

[#Ip-342] Upgrade fp-ts #36

merged 30 commits into from
Sep 21, 2021

Conversation

gquadrati
Copy link
Contributor

@gquadrati gquadrati commented Aug 11, 2021

List of Changes

  • Upgrade fp-ts
  • upgrade io-ts
  • upgrade @pagopa/ts-commons
  • moved to new implementation
  • replaced fp-ts toString with a new function that proxies JSON.stringify

Motivation and Context

Upgrade to latest fp-ts and io-ts

How Has This Been Tested?

  • Unit tests
  • Integration tests in io-mock

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gquadrati gquadrati requested a review from balanza as a code owner August 11, 2021 15:02
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Aug 11, 2021

Warnings
⚠️ This PR changes a total of 1163 LOCs, that is more than a reasonable size of 250. Consider splitting the pull request into smaller ones.
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

@pagopa/openapi-codegen-ts

Author: https://www.pagopa.gov.it/

Description: Tools and utilities for the IO project

Homepage: https://github.com/pagopa/io-utils#readme

Created9 months ago
Last Updatedabout 1 month ago
LicenseMIT
Maintainers5
Releases8
Direct Dependencies@pagopa/ts-commons, fs-extra, nunjucks, prettier, safe-identifier, swagger-parser, write-yaml-file and yargs
This README is too long to show.

New dependencies added: @pagopa/openapi-codegen-ts.

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 5385bd1

@gquadrati gquadrati force-pushed the IP-342--upgrade-fp-ts branch from 32c93bf to 8416227 Compare September 3, 2021 09:31
@balanza balanza merged commit 1d4e631 into master Sep 21, 2021
@balanza balanza deleted the IP-342--upgrade-fp-ts branch September 21, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants