[#ICC-159] Migrate pushNotification.notifyMessage from durable function to queue #57
Conversation
Example of PR titles that include pivotal stories:
|
|
Hi @fabriziopapi, may you share some insight about the statement "The DF-based notify message performance are not enough reliable"? We are going to take some choices for another project... |
| T.sequenceArray, | ||
| // eslint-disable-next-line functional/immutable-data | ||
| T.map(notifyMessages => (context.bindings.notifyMessages = notifyMessages)), | ||
| T.map(() => "-1") // There is no orchestrator_id to return |
There was a problem hiding this comment.
Why not refactoring also this return? We are trying to get rid of the orchestrator, can't we refactor the caller to get another type of return?
There was a problem hiding this comment.
For queue implementation there is nothing usefull to return: we'll switch it to void at the end of refactor.
|
Kudos, SonarCloud Quality Gate passed!
|
fabriziopapi
changed the title
add FF for notify via queue feature
|
Kudos, SonarCloud Quality Gate passed!
|
BurnedMarshal
deleted the
IC-448--migrate-pushnotification-notifymessage-from-durable-function-to-queue
branch
Re-implement the NotifyMessage orchestrator/activity (io-functions-pushnotif) without the Durable Function.
The NotifyMessage operation will be implemented used a storage queue: the retry mechanism will be provided by the azure function trigger.
List of Changes
Add a notify message implementation based on a storage queue
Replace the notifications handler to use the queue-based notify message implementation
Add Feature Flag to route to notify via queue implementation
Motivation and Context
The DF-based notify message performance are not enough reliable.
How Has This Been Tested?
unit test
Screenshots (if appropriate):
Types of changes
Checklist: