-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#172766902] Add rate limits api info #55
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 8 8
Lines 366 366
Branches 47 47
=======================================
Hits 305 305
Misses 60 60
Partials 1 1 Continue to review full report at Codecov.
|
Example of PR titles that include pivotal stories:
Generated by 🚫 dangerJS |
All API requests are subject to rate limits. | ||
Rate limits apply on a subscription key basis. | ||
The current rate limit is of `150 requests` every `5 seconds`. | ||
If limits are exceeded the API server returns a 429 (Too Many Requests) response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we return some headers to the caller ? (ie x-retry-after)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for now, but we can add both retry-after and remaining-calls count as headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok (so we will add those headers here when ready 👍 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we return the headers now? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping :)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Draft until limits are approved