[SIW-777,SIW-775] Add check to start proximity manager only once and …

…removeListeners method (#17) * Remove key parser * Remove console log Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it> * chore: add isStarted check * chore;: update version * chore: add new event --------- Co-authored-by: grausof <grausof@gmail.com>
pagopa · Dec 21, 2023 · 6cb526f · 6cb526f
1 parent 0c9a788
commit 6cb526f
Show file tree

Hide file tree

Showing 4 changed files with 65 additions and 29 deletions.
diff --git a/example/src/App.tsx b/example/src/App.tsx
@@ -36,6 +36,9 @@ export default function App() {
       case 'ON_BLE_STOP':
         setIsStarted(false);
         break;
+      case 'ON_DOCUMENT_PRESENTATION_COMPLETED':
+        stopProximityManager();
+        break;
       default:
         break;
     }
@@ -94,6 +97,7 @@ export default function App() {
     ProximityManager.stop().then(() => {
       setQrCodeUri(undefined);
       setIsStarted(false);
+      ProximityManager.removeListeners();
     });
   };
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@pagopa/io-react-native-proximity",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "description": "A RN library to get proximity flow based on ISO-18013",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",

diff --git a/src/proximity-manager/index.ts b/src/proximity-manager/index.ts
@@ -96,37 +96,44 @@ const ProximityManager = () => {
     state: string;
   };
 
+  // This flag is used to understand if the BLE manager is started
+  // and avoid starting it multiple times causing multiple
+  // connection to the same peripheral
+  let isStarted = false;
+
   const start = () => {
     return new Promise<void>(async (resolve, reject) => {
       await session.start();
+      randomVerifierUUID = uuid.v4().toString();
+      if (!isStarted) {
+        BleManager.start({ showAlert: false })
+          .then(() => {
+            bleManagerEmitter.addListener(
+              'BleManagerDiscoverPeripheral',
+              handleDiscoverPeripheral
+            );
+            bleManagerEmitter.addListener('BleManagerStopScan', handleStopScan);
 
-      BleManager.start({ showAlert: false })
-        .then(() => {
-          bleManagerEmitter.addListener(
-            'BleManagerDiscoverPeripheral',
-            handleDiscoverPeripheral
-          );
-          bleManagerEmitter.addListener('BleManagerStopScan', handleStopScan);
-
-          bleManagerEmitter.addListener(
-            'BleManagerDisconnectPeripheral',
-            handleDisconnectedPeripheral
-          );
-
-          bleManagerEmitter.addListener(
-            'BleManagerDidUpdateValueForCharacteristic',
-            handleUpdateValueForCharacteristic
-          );
-          eventManager.emit('onEvent', {
-            type: 'ON_BLE_START',
-            message: 'ble manager is started.',
+            bleManagerEmitter.addListener(
+              'BleManagerDisconnectPeripheral',
+              handleDisconnectedPeripheral
+            );
+
+            bleManagerEmitter.addListener(
+              'BleManagerDidUpdateValueForCharacteristic',
+              handleUpdateValueForCharacteristic
+            );
+            isStarted = true;
+            resolve();
+          })
+          .catch((error) => {
+            reject(error);
           });
-          randomVerifierUUID = uuid.v4().toString();
-          resolve();
-        })
-        .catch((error) => {
-          reject(error);
-        });
+      }
+      eventManager.emit('onEvent', {
+        type: 'ON_BLE_START',
+        message: 'ble manager is started.',
+      });
     });
   };
 
@@ -141,6 +148,10 @@ const ProximityManager = () => {
 
     const messageToSend = encode(responseData);
     await sendMdocResponseChunks(messageToSend);
+    eventManager.emit('onEvent', {
+      type: 'ON_DOCUMENT_PRESENTATION_COMPLETED',
+      message: 'Document presentation completed.',
+    });
   };
 
   const sendMdocResponseChunks = async (messageToSend: Buffer) => {
@@ -236,7 +247,6 @@ const ProximityManager = () => {
             console.log('Unable to disconnect from pheripheral', error);
           }
         }
-
         resolve();
         eventManager.emit('onEvent', {
           type: 'ON_BLE_STOP',
@@ -466,6 +476,15 @@ const ProximityManager = () => {
     });
   };
 
+  /**
+   * This function is to remove all the listeners
+   * @example
+   * ProximityManager.removeListeners();
+   */
+  const removeListeners = () => {
+    eventManager.removeAllListeners();
+  };
+
   const setOnDocumentRequestHandler = (
     handler: typeof handleDocumentsRequest
   ) => {
@@ -511,6 +530,7 @@ const ProximityManager = () => {
     setListeners,
     setOnDocumentRequestHandler,
     dataPresentation,
+    removeListeners,
     stop,
   };
 };

diff --git a/src/utils/EventManager.ts b/src/utils/EventManager.ts
@@ -12,7 +12,8 @@ type EventType =
   | 'ON_CHARACTERISTIC_CHANGED'
   | 'ON_BLE_ERROR'
   | 'ON_SESSION_ESTABLISHMENT'
-  | 'ON_DOCUMENT_REQUESTS_RECEIVED';
+  | 'ON_DOCUMENT_REQUESTS_RECEIVED'
+  | 'ON_DOCUMENT_PRESENTATION_COMPLETED';
 
 export type EventData = {
   message: string;
@@ -42,6 +43,7 @@ export type EventData = {
 const createEventManager = () => {
   const listeners: { [key: string]: Array<(eventData: EventData) => void> } =
     {};
+
   const addListener = (
     eventName: string,
     callback: (eventData: EventData) => void
@@ -51,6 +53,7 @@ const createEventManager = () => {
     }
     listeners[eventName]?.push(callback);
   };
+
   const removeListener = (
     eventName: string,
     callback: (eventData: EventData) => void
@@ -61,14 +64,23 @@ const createEventManager = () => {
       );
     }
   };
+
+  const removeAllListeners = () => {
+    Object.keys(listeners).forEach((eventName) => {
+      listeners[eventName] = [];
+    });
+  };
+
   const emit = (eventName: string, data: EventData) => {
     if (listeners[eventName]) {
       listeners[eventName]?.forEach((listener) => listener(data));
     }
   };
+
   return {
     addListener,
     removeListener,
+    removeAllListeners,
     emit,
   };
 };