Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5807] feat: Added fields for PSP template #608

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[SELC-5807] feat: Added fields for PSP template #608

merged 3 commits into from
Nov 19, 2024

Conversation

giampieroferrara
Copy link
Collaborator

@giampieroferrara giampieroferrara commented Nov 18, 2024 •
edited
Loading

List of Changes

Fixed condition into InstitutionUtils
Added new fields into map for PSP template

Motivation and Context

Inability to make a checkbox dynamic

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giampieroferrara giampieroferrara requested a review from a team as a code owner November 18, 2024 17:11
@github-actions github-actions bot added functions Changes are related to functions onboarding-ms labels Nov 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@giampieroferrara giampieroferrara merged commit a253eff into main Nov 19, 2024
17 of 18 checks passed
@giampieroferrara giampieroferrara deleted the feature/SELC-5807 branch November 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-putzu andrea-putzu andrea-putzu approved these changes

Assignees
No one assigned
Labels
functions Changes are related to functions onboarding-ms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giampieroferrara @andrea-putzu