-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test folder in npm #203
Comments
I'm happy to make a PR if this makes sense. |
Yes, no need for the test folder to be in NPM. PR accepted 😊 |
Cool. As promised: #205 |
nmeylan
pushed a commit
to nmeylan/madge
that referenced
this issue
Jan 7, 2020
…lder-from-npm) [Fixes pahen#203] Exclude test folder from npm registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've just added madge to a project; I'm using it for its ability to detect circular import dependencies - works like a charm! Thanks for this tool, they're maddening to track down without it.
However since we also have
retirejs
checking for package vulnerabilities, I'm getting a warning from a copy of JQuery you have in yourtest
folder:Doesn't look like this is used at runtime based on the fact that it's in your
test
folder, so no big deal, I'll work around it for now.However I'm wondering if
test
even belongs in the npm repository to begin with. Would you consider adding it to a.npmignore
so that only things needed for consumers at runtime are shipped to the npm registry when you publish?The text was updated successfully, but these errors were encountered: