Show skipped files as warnings (disable with —-no-warning) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job with the thoroughness of the solution. |
|
Thanks! But now I'm starting to think it's maybe better to have warnings disabled by default? Most of the time you don't want to see them. |
|
I decided to change to |
|
Yeah, having to opt-out of warnings felt like a breaking change. Opting-in is definitely better. |
|
Yes, I agree! Renamed |
|
Feel better ❤️ |
|
Thanks Joel! |
nmeylan
pushed a commit
to nmeylan/madge
that referenced
this pull request
Jan 7, 2020
Show skipped files as warnings (disable with —-no-warning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107