Support .tsx files and specifying a tsconfig #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates depdendency-tree to 6.5.0 to gain support for
.tsx
files and the ability to specify a custom tsconfig to control module resolution.Mostly fixes #189. Fixes #167. Fixes #128 (as long as you reference your tsconfig)
I'm running into an issue where folder imports like
./components
, which should resolve to./components/index.ts
are not being resolved at all but that's because filing-cabinet seems to use typescript's "classic" module resolution by default instead of the "node" style which supports that form, and when I setmoduleResolution: "node"
in my tsconfig filing-cabinet crashes. However I'm pretty sure that is either a bug in filing-cabinet or typescript itself rather than something to be fixed in madge. I'll delve into that and open an issue in the relevant place.