Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .tsx files and specifying a tsconfig #193

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Support .tsx files and specifying a tsconfig #193

merged 1 commit into from
Jan 4, 2019

Conversation

BPScott
Copy link
Contributor

@BPScott BPScott commented Jan 3, 2019

Updates depdendency-tree to 6.5.0 to gain support for .tsx files and the ability to specify a custom tsconfig to control module resolution.

Mostly fixes #189. Fixes #167. Fixes #128 (as long as you reference your tsconfig)

I'm running into an issue where folder imports like ./components, which should resolve to ./components/index.ts are not being resolved at all but that's because filing-cabinet seems to use typescript's "classic" module resolution by default instead of the "node" style which supports that form, and when I set moduleResolution: "node" in my tsconfig filing-cabinet crashes. However I'm pretty sure that is either a bug in filing-cabinet or typescript itself rather than something to be fixed in madge. I'll delve into that and open an issue in the relevant place.

@BPScott
Copy link
Contributor Author

BPScott commented Jan 4, 2019

dependents/node-filing-cabinet#75 is the PR that fixes the crashes when using a tsconfig that contains moduleResolution: "node". It might be worth waiting till that gets merged, released and included in depdendency-tree to save needing a second PR for another version bump.

@BPScott
Copy link
Contributor Author

BPScott commented Jan 4, 2019

Have force-pushed an extra test for ./folder resolving to ./folder/index.ts when using moduleResolution: 'node' now that dependents/node-filing-cabinet#75 has been merged.

@mrjoelkemp
Copy link
Contributor

6.4.1 of dependency tree has been released with the new filing-cabinet changes. Great work here.

@BPScott
Copy link
Contributor Author

BPScott commented Jan 4, 2019

Bumped dependency-tree up to 6.5.0. This is now ready to roll.

Thank you for your super speedy release wrangling @mrjoelkemp <3

@pahen pahen merged commit 713d6e7 into pahen:master Jan 4, 2019
@pahen
Copy link
Owner

pahen commented Jan 4, 2019

Great work @BPScott and @mrjoelkemp <3 I'll create a new release!

@pahen
Copy link
Owner

pahen commented Jan 4, 2019

I'll create a new release when dependents/node-precinct#56 has been merged :)

@mrjoelkemp
Copy link
Contributor

Done and v7.0.0 of dependency-tree has been released. Thanks for all of the help.

@pahen
Copy link
Owner

pahen commented Jan 7, 2019

Thank! Released Madge v3.4.0 now :)

nmeylan pushed a commit to nmeylan/madge that referenced this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants