Improve Graphviz support detection #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation was assuming that an error was always caused by the Graphviz binary not available in the path. However an error can also be thrown when Graphviz is missing an external dependencies for example. As far as I know ENOENT stands for a no entry error which indicates that something wasn't found. In this case it should be safe to assume that Graphviz isn't available in the path. See: https://stackoverflow.com/q/66602685/1244884
customcommander
force-pushed
the
improve-graphviz-detection
branch
from
a03392a
to
73c6126
Compare
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation was assuming that an error was always caused by
the Graphviz binary not available in the path.
However an error can also be thrown when Graphviz is missing
an external dependencies for example.
As far as I know ENOENT stands for a no entry error which
indicates that something wasn't found. In this case it should
be safe to assume that Graphviz isn't available in the path.
See: https://stackoverflow.com/q/66602685/1244884