Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump 'detective-typescript' package to allow newer TS versions #321

Merged
merged 2 commits into from
Jan 28, 2023
Merged

chore: bump 'detective-typescript' package to allow newer TS versions #321

merged 2 commits into from
Jan 28, 2023

Conversation

ZuBB
Copy link
Contributor

@ZuBB ZuBB commented Aug 20, 2022

Due to the dependencies of the 'detective-typescript' package, users of madge are getting a warning about TS versions that are not supported. With this bump, we allow them to go further than 4.4 (released 1y ago)

Also fixes #316

@kamiazya kamiazya added this to the 6.0.0 milestone Jan 28, 2023
Copy link
Collaborator

@kamiazya kamiazya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I ran it on local with "typescript":"^4.9.4" and it worked fine.

@kamiazya kamiazya merged commit 54340e8 into pahen:master Jan 28, 2023
@kamiazya kamiazya linked an issue Jan 28, 2023 that may be closed by this pull request
@kamiazya kamiazya mentioned this pull request Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial type imports does not work Warning about TypeScript 4.6 not supported
4 participants