Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle collect tsconfig's extends fileds #349

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Handle collect tsconfig's extends fileds #349

merged 1 commit into from
Jan 29, 2023

Conversation

kamiazya
Copy link
Collaborator

@kamiazya kamiazya commented Jan 28, 2023 •
edited
Loading

Resolved with the restriction that tsconfig is only resolved if specified by path to avoid breaking the API used by the user.

fix #323

PabloLION
PabloLION reviewed Jan 28, 2023
View reviewed changes
lib/api.js Show resolved Hide resolved
@kamiazya kamiazya self-assigned this Jan 28, 2023
@kamiazya kamiazya added the bug label Jan 28, 2023
vikingair
vikingair approved these changes Jan 29, 2023
View reviewed changes
Copy link
Collaborator

@vikingair vikingair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabloLION PabloLION merged commit c1b4aaa into master Jan 29, 2023
@kamiazya kamiazya deleted the handle-tsconfig-correctly branch January 29, 2023 08:25
@kamiazya kamiazya added this to the 6.0.0 milestone Jan 29, 2023
@kamiazya kamiazya mentioned this pull request Jan 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloLION PabloLION PabloLION left review comments

@vikingair vikingair vikingair approved these changes

Assignees

@kamiazya kamiazya

Labels
bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

tsconfig.json with extends not handled correctly
3 participants
@kamiazya @vikingair @PabloLION