Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deploy to NPM from Travis build #354

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Remove deploy to NPM from Travis build #354

merged 1 commit into from
Jan 30, 2023

Conversation

pahen
Copy link
Owner

@pahen pahen commented Jan 30, 2023 •
edited
Loading

It's now handled when running "npm run release" task instead. Will require user to be a maintainer on the NPM madge package. Also deleted the old access tokens used by the Travis build to access NPM.

@pahen pahen requested a review from kamiazya January 30, 2023 13:02
kamiazya
kamiazya approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@kamiazya kamiazya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kamiazya kamiazya added the dev dev-related topic of this repo label Jan 30, 2023
@kamiazya kamiazya merged commit ba2b3e7 into master Jan 30, 2023
@kamiazya kamiazya deleted the no-travis-npm-deploy branch January 30, 2023 13:21
@kamiazya kamiazya added this to the 6.1.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamiazya kamiazya kamiazya approved these changes

Assignees

@pahen pahen

Labels
dev dev-related topic of this repo
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pahen @kamiazya