Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to not print the index #387

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Conversation

mlostekk
Copy link
Contributor

As it is very helpful to sort the lines in the output of a circular dependency output file, I have added this option. This makes sorting the file easier as I do not have to remove hundreds of lines of indices first. With sorted files, reading the output and understanding big bottlenecks easier.

Copy link
Collaborator

@PabloLION PabloLION left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice call and I'm seeing it to be useful for piping!

Also, please add a test like

desc "CIRCULAR (FOUND, NO INDEX)"
./bin/cli.js test/cjs/circular/a.js -c --no-index

to test/output.sh

bin/cli.js Outdated Show resolved Hide resolved
@PabloLION PabloLION merged commit 6142cc6 into pahen:master Oct 22, 2023
@PabloLION
Copy link
Collaborator

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants