Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: edit test/output.sh comply with POSIX #391

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

PabloLION
Copy link
Collaborator

This is my solution to #380 and #390.
Maybe someone else can review them?

@legobeat
Copy link
Contributor

LGTM!

@PabloLION
Copy link
Collaborator Author

@legobeat I just find that I can't review myself, which blocks the merging: I cannot merge without any review. If it's left here for a while, I guess the solution will be to use another account, or have someone else to make a same PR.

@vikingair
Copy link
Collaborator

Thanks @PabloLION

@vikingair vikingair merged commit 6e0acb2 into pahen:master Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants