Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to dependency-tree@11 #417

Merged
merged 2 commits into from
May 22, 2024
Merged

Update to dependency-tree@11 #417

merged 2 commits into from
May 22, 2024

Conversation

vikingair
Copy link
Collaborator

In this PR I updated to this release: https://github.com/dependents/node-dependency-tree/releases/tag/v11.0.0

Since the dependency dropped support for Node < 18, I did it here as well and adjusted the pipeline.

@vikingair
Copy link
Collaborator Author

@pahen How do you think about this?

I also tried adding a test to see that scanning Vue SFC files works, but couldn't find how I need to configure the detective to scan these files correctly. Maybe after merging this PR you have an idea?

@vikingair vikingair linked an issue May 21, 2024 that may be closed by this pull request
It seems like the integrated npm cache does not depend on the used node version and parallel read/writes and node dependent updates don't work properly, resulting in non-ending builds. Going back to previous behavior of using no caches for node modules.
@pahen pahen self-requested a review May 22, 2024 12:13
@pahen
Copy link
Owner

pahen commented May 22, 2024

@pahen How do you think about this?

I also tried adding a test to see that scanning Vue SFC files works, but couldn't find how I need to configure the detective to scan these files correctly. Maybe after merging this PR you have an idea?

Looks good! I don't use Vue myself but I suppose looking at this test might give us some help: https://github.com/dependents/detective-vue2/blob/main/test/test.js

@vikingair vikingair merged commit 5c9b1c3 into pahen:master May 22, 2024
2 checks passed
@vikingair
Copy link
Collaborator Author

https://github.com/dependents/detective-vue2/blob/main/test/test.js

Will take a look and possibly add there more test cases. Especially, for different arrangements of top level tags and e.g. setup-syntax support. Will come back with my findings, once that would work, and add some tests for madge as well.

@vikingair
Copy link
Collaborator Author

Found the root cause of my issue and created a PR to fix it: dependents/detective-vue2#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update typescript version for v7
2 participants