-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0 #96
Version 1.0 #96
Conversation
Wanna give it a try @mrjoelkemp @Kriegslustig ? :) |
I can give it a spin on a few repos tonight. Excited to see this land! |
That would be awesome @mrjoelkemp. I'm very excited to see this land too! |
78bb399
to
9fff524
Compare
I tried running What's a bit puzzling is that there are files within node_modules that are in You may need to filter out |
Thanks! Good point! I'll take a look at that :) |
Should be fixed now @mrjoelkemp! But avoid running it in DEBUG mode since it will be much slower. It took 22s for me now to run |
Nice job with the fix! Looks good to me. Tried it on my ES6 work project and it looks great. Looking forward to seeing the errors that users report. I'll be sure to prioritize any dependency-tree bugs as they come up. |
I tried using it on a typescript project but it only works on some files. On Some files I get:
Will try to debug it further and report back. Update
content = content.replace(/private\s/, '').replace(/public\s/, '').replace(/protected\s/, ''); |
How do you execute madge? It would be nice to see the parse error in precinct @mrjoelkemp. Maybe change to something like |
I applied your change and now I get:
|
The change could be made but any parse errors (syntax errors or unknown tokens) trigger it, so the error message is implied. I'd gladly merge a PR that adds more helpful logging though. To my knowledge, Typescript isn't supported via babylon (dependency-tree's parser). This is another case for detective-typescript. We'd need an associated partial resolver registered in filing-cabinet. I don't have capacity to take this on at the moment unless there is a large demand. I'll happily review prs though. |
Thanks for reporting @frederikschubert! I'm moving TypeScript support (#64) into the 1.1.0 milestone instead of this release. |
720087a
to
9ece95a
Compare
This is what's going to be Madge 1.0. See changelog and updated documentation.
Want to be a beta tester? Give it a spin and install it like this:
npm install -g git://github.com/pahen/madge.git#v1
Would love to get some feedback!
Fixes #88
Fixes #68
Fixes #57
Fixes #56
Fixes #52