uses dependency URI instead of cache artifact name for classpath #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-david-osullivan
added
semver:patch
pivotal-david-osullivan
force-pushed
the
libpak-fix
branch
from
ed27f87 to
5a25af8
Compare
dmikusa
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The change in paketo-buildpacks/libpak#273 introduced a bug where the artifact name was used as the classpath entry - this lead to the SHA value being added to the classpath rather than the library name. This PR uses the dependency URI base name instead which resolves to the actual library name.
Use Cases
Checklist