Gh 212 #213
Gh 212 #213
Conversation
When the buildpack runs, it will locate the dist zip script to execute. If that script is found, then we also mark it as `0755`. This happens unconditionally, but we do not fail if there is an error. We just log a warning and proceed. It really shouldn't fail but maybe if the file had weird file permissions/ownership. The choice to do this unconditionally is that it is slightly simpler. Checking and then setting is two operations. If thereis a preference to doing it that way, making the switch is easy enough. Just let me know Signed-off-by: Daniel Mikusa <dan@mikusa.com>
dmikusa
added
type:bug
|
Hello! Or maybe a new sample with |
|
The sample is difficult because it auto-generates the startup script. That means, it always generates it correctly with the right permissions. I did some manual testing with the sample app, but I had to build the ZIP, extract the files, change the permissions, make a new archive, and test with that. I went a different route and covered this test case in the build_test.go with a test script that is generated by the test without the right permissions. It was easier to control and make the test predictable this way. I feel like that gives us pretty good coverage for this problem as well. |
Yes, I see that, that's perfect - straight to the point! Thanks! |
Summary
Resolves #212
Use Cases
Make sure script is always executable.
Checklist