Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to automatically update .NET Core SDK compatibility table #266

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

sophiewigmore
Copy link
Member

Summary

Helps resolve #223. Moved from paketo-buildpacks/github-config#351

This code is largely copied over from the previous iteration of this automation that was in the update-dotnet-sdks-and-compat-table Concourse task. It has been converted into a Github Action.

It takes in a buildpack.toml and a new SDK version, and replaces and updates the compatibility table to include the mapped runtime/SDK versions. Almost all of the functionality and logic is the same as it was when we used the Concourse task. The major difference is that the associated runtime version is no longer an input (we now look it up on .NET Core's official release page), and the release JSON is now looked up instead of being passed in as a file.

This will be consumed by a workflow in #256

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore sophiewigmore requested a review from a team as a code owner September 20, 2021 21:40
@sophiewigmore sophiewigmore changed the title add SDK compatibility update action Add action to automatically update .NET Core SDK compatibility table Sep 20, 2021
Copy link
Contributor

@ForestEckhardt ForestEckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with how this looks!

@ForestEckhardt ForestEckhardt merged commit c55d8c4 into main Sep 21, 2021
@ForestEckhardt ForestEckhardt deleted the compatibility-action branch September 21, 2021 13:59
arjun024 added a commit that referenced this pull request Sep 21, 2021
Fixing a minor typo noticed while reading #266
@arjun024 arjun024 mentioned this pull request Sep 21, 2021
5 tasks
ForestEckhardt pushed a commit that referenced this pull request Sep 22, 2021
Fixing a minor typo noticed while reading #266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume the SDK dependency from the dep-server
2 participants