Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes use of Buildpack.SHA256 field #17

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Removes use of Buildpack.SHA256 field #17

merged 2 commits into from
Sep 23, 2021

Conversation

ForestEckhardt
Copy link
Contributor

This field is not an official part of the spec and therefore should not
be part of the config struct

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ForestEckhardt
Removes use of Buildpack.SHA256 field
4d6612f 
This field is not an official part of the spec and therefore should not
be part of the config struct
@ForestEckhardt ForestEckhardt requested a review from a team as a code owner September 21, 2021 20:49
@ForestEckhardt ForestEckhardt mentioned this pull request Sep 21, 2021
Merged
5 tasks
@sophiewigmore sophiewigmore merged commit b3d9187 into main Sep 23, 2021
@sophiewigmore sophiewigmore deleted the remove-field branch September 23, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewigmore sophiewigmore sophiewigmore approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForestEckhardt @sophiewigmore