Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds convenience method to generate a file listing & return the hash of the listing #73

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Aug 16, 2021

Summary

The file listing mechanism is typically used to detect if changes have occurred under a directory. Rather than have the full details of the file listing, it's sufficient to compare hashes of the file listings. The hash also results in a smaller value, if you need to store that in metadata.

Use Cases

Resolves #25

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Aug 16, 2021
@dmikusa dmikusa requested a review from a team August 16, 2021 12:43
Copy link
Contributor

@pivotal-david-osullivan pivotal-david-osullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…of the listing

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa merged commit f35c763 into main Aug 16, 2021
@dmikusa dmikusa deleted the gh_issue_25 branch August 16, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileLists and MavenFileLists Metadata is too big
2 participants