Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to packit v2 #364

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Upgrades to packit v2 #364

merged 2 commits into from
Apr 1, 2022

Conversation

ForestEckhardt
Copy link
Contributor

@ForestEckhardt ForestEckhardt commented Mar 31, 2022 •
edited
Loading

  • Removes built_at for more reproducible builds
  • Cleans up unit tests
  • Adds missing error cases
  • Removes unneeded copy of configure binary to bin, this is no longer
    necessary because this buildpack is using configure as an exec.d process
    therefore the binary no longer needs to be on the path to be called by a
    profile.d script
  • Adds layer reuse logging

Resolves #348
Resolves #360

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ForestEckhardt
Upgrades to packit v2
2948060 
- Removes built_at for more reproducible builds
@ForestEckhardt
Cleans unit tests
17d448d 
- Adds missing error cases
- Removes unneeded copy of configure binary to bin, this is no longer
necessary because this buildpack is using configure as an exec.d process
therefore the binary no longer needs to be on the path to be called by a
profile.d script
- Adds layer reuse logging
@ForestEckhardt ForestEckhardt marked this pull request as ready for review March 31, 2022 19:43
@ForestEckhardt ForestEckhardt requested a review from a team as a code owner March 31, 2022 19:43
@thitch97 thitch97 added the semver:patch A change requiring a patch version bump label Apr 1, 2022
@thitch97 thitch97 merged commit 2e96ec4 into main Apr 1, 2022
@thitch97 thitch97 deleted the packit-v2 branch April 1, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thitch97 thitch97 thitch97 approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conform to RFC0043: Reproducible Builds Upgrade to packit v2
2 participants
@ForestEckhardt @thitch97