Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixup the removal of bionic #1054

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: fixup the removal of bionic #1054

merged 1 commit into from
Oct 31, 2024

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Oct 30, 2024 •
edited
Loading

Summary

  • we don't need to node.js deps for noble as they are the same as for jammy and restoring the * in the stack line means noble can use then as well.
  • I had missed the strip-components field which is needed
  • The version update script did not remove all mentions of bionic so remove them separately from the update to the Node.js versions supported
  • the builpackless builder without jammy in the name uses bionic so remove it from the list of builders in integration.json

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@mhdawson
fix: fixup the removal of bionic
aa65354 
- we don't need to node.js deps for noble as they are the
  same as for jammy and restoring the * in the stack line  means
  noble can use then as well.
- I had missed the strip-components field which is needed
- The version update script did not remove all mentions of bionic so
  remove them separately from the update to the Node.js versions
  supported
- the builpackless builder without jammy in the name uses bionic
  so remove it from the list of builders in integration.json

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson mhdawson requested a review from a team as a code owner October 30, 2024 21:00
@mhdawson mhdawson added the semver:major A change requiring a major version bump label Oct 30, 2024
pacostas
pacostas approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@pacostas pacostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas pacostas merged commit c9486df into paketo-buildpacks:main Oct 31, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacostas pacostas pacostas approved these changes

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:major A change requiring a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhdawson @pacostas