Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update version of Node.js used for testing #873

Merged
merged 1 commit into from
Jun 19, 2024
Merged

chore: update version of Node.js used for testing #873

merged 1 commit into from
Jun 19, 2024

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 19, 2024 •
edited
Loading

Summary

Update tests to use Node.js 18 instead of 16 since support for 16 has been removed

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@mhdawson
chore: update version of Node.js used for testing
f12b2af 
Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson mhdawson requested a review from a team as a code owner June 19, 2024 16:56
@mhdawson mhdawson added the semver:major A change requiring a major version bump label Jun 19, 2024
pacostas
pacostas approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@pacostas pacostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 7acdbbc into paketo-buildpacks:main Jun 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacostas pacostas pacostas approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@TisVictress TisVictress Awaiting requested review from TisVictress TisVictress is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:major A change requiring a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhdawson @pacostas