Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Exists function #249

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Adds Exists function #249

merged 2 commits into from
Nov 30, 2021

Conversation

ForestEckhardt
Copy link
Contributor

  • This function tests if a file or directory exists and returns bool in
    response. This is in an attempt to clean up file testing code across our
    buildpack and hopefully make to logic more clear.

Resolves #160 which has become stale. This implementation conforms with the conversation on the PR.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ForestEckhardt
Adds Exists function
c5143f2 
- This function tests if a file or directory exists and returns bool in
response. This is in an attempt to clean up file testing code across our
buildpack and hopefully make to logic more clear.
@ForestEckhardt ForestEckhardt requested a review from a team as a code owner November 15, 2021 16:44
@sophiewigmore sophiewigmore added the semver:minor A change requiring a minor version bump label Nov 30, 2021
@sophiewigmore sophiewigmore merged commit ce11476 into main Nov 30, 2021
@sophiewigmore sophiewigmore deleted the fs-exist branch November 30, 2021 17:04
@sophiewigmore sophiewigmore mentioned this pull request Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewigmore sophiewigmore sophiewigmore approved these changes

@fg-j fg-j Awaiting requested review from fg-j fg-j is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForestEckhardt @sophiewigmore