Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NopArchive
will now no longer write directly to the destination if aname is not given because it now set a default name (
artifact
). If youwere using the generic
Archive
type you will see no difference but thosewho were using the type directly must now specify a directory as the
destination, not a file name.
NewExecutable()
now conforms to the same api as the other archiveinstantiation functions excepting only a reader and allowing individuals
to set the file name using a
WithName()
option with mirrors thebehavior of all other archive objects.
-
Executable
now has a default file name (artifact
) if you were usingthe generic
Archive
type you will see no difference however because theExecutable instantiation function no longer requires a name a default is
now assigned on instantiation the same way it is done for the
NopArchive
.Executable
no longer places the executable in a directory namebin
nor does it create all directories in the destination path. I felt that
automatically placing the executable in a
bin
directory felt toopinionated, I think that it is more than reasonable for a user to want
to download and executable and not want to have it placed in a directory
named
bin
and this default behavior hinders that user. I think that itis more than reasonable to expect that the destination given is a
bin
directory if that is the desired effect. As for no longer creating all
of directories in the destination path,
NopArchive
is precedent settingas it expects to write files only to destinations that exist already.
Checklist