Simplify SBOM test assertions #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid brittleness from irrelevant SBOM content changes
sophiewigmore
suggested changes
Jan 3, 2022
|
@fg-j it looks like a couple structs got left behind and are causing linting errors. Once that's fixed this PR is good! |
sophiewigmore
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have noticed over the past weeks that our SBOM tests were quite brittle – frequently requiring intervention when upgrading syft versions – despite there not being important changes to the outputted JSON. I took a shot at stripping down the assertions to minimize the amount we're just testing syft's functionality.
Use Cases
Checklist