Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds sbom.NewSBOM #327

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Adds sbom.NewSBOM #327

merged 1 commit into from
Apr 12, 2022

Conversation

ryanmoran
Copy link
Member

Summary

Allows users to construct an sbom.SBOM given that they already have a syft.SBOM.

Use Cases

There are cases where users might already have a syft.SBOM for whatever reason and they still want to take advantage of the formatting code that is provided in the sbom package. We should allow them to convert their syft.SBOM into an sbom.SBOM so that they can call into the formatting code paths.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ryanmoran ryanmoran requested a review from a team as a code owner April 11, 2022 16:00
@fg-j
Copy link

fg-j commented Apr 11, 2022

Is this an attempt to address the underlying concern in #320 ?

@ryanmoran
Copy link
Member Author

Specifically, I'd like to use this in the stacks codebase that I am refactoring, but it could also help, if not fully resolve, #320.

@sophiewigmore
Copy link
Member

sophiewigmore commented Apr 12, 2022 •
edited
Loading

@ryanmoran patch change? Or minor since it's new functionality?

@ryanmoran ryanmoran added the semver:minor A change requiring a minor version bump label Apr 12, 2022
@sophiewigmore sophiewigmore merged commit b5dff77 into v2 Apr 12, 2022
@sophiewigmore sophiewigmore deleted the new-sbom branch April 12, 2022 18:46
@fg-j fg-j mentioned this pull request Apr 14, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewigmore sophiewigmore sophiewigmore approved these changes

@ForestEckhardt ForestEckhardt Awaiting requested review from ForestEckhardt ForestEckhardt is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

@fg-j fg-j Awaiting requested review from fg-j fg-j is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
Paketo Workstreams
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanmoran @fg-j @sophiewigmore