Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds scribe.WithPrefix option for scribe.Writer #353

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Adds scribe.WithPrefix option for scribe.Writer #353

merged 1 commit into from
Jun 23, 2022

Conversation

ryanmoran
Copy link
Member

Summary

Allows users to configure a scribe.Writer with a prefix.

Use Cases

This will be useful in implementing paketo-buildpacks/jam#83. We can use it to display interleaved log output from different docker build streams.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ryanmoran ryanmoran requested a review from a team as a code owner June 22, 2022 22:33
@ryanmoran ryanmoran requested review from sophiewigmore and fg-j June 22, 2022 22:33
@ForestEckhardt ForestEckhardt added the semver:minor A change requiring a minor version bump label Jun 22, 2022
@ForestEckhardt ForestEckhardt merged commit 115372f into v2 Jun 23, 2022
@ForestEckhardt ForestEckhardt deleted the scribe-prefix branch June 23, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForestEckhardt ForestEckhardt ForestEckhardt approved these changes

@sophiewigmore sophiewigmore Awaiting requested review from sophiewigmore sophiewigmore is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

@fg-j fg-j Awaiting requested review from fg-j fg-j is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanmoran @ForestEckhardt