Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for wild-card stacks in dependencies #376

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add support for wild-card stacks in dependencies #376

merged 1 commit into from
Aug 4, 2022

Conversation

sambhav
Copy link

@sambhav sambhav commented Aug 4, 2022 •
edited
Loading

Signed-off-by: Sambhav Kothari skothari44@bloomberg.net

Summary

Resolves #375

Use Cases

There are various binaries that are compatible with all linux stacks. We should add support for * stack id in metadata dependencies.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sambhav
Add support for wild-card stacks in dependencies
0b99aa5 
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
@sambhav sambhav requested a review from a team as a code owner August 4, 2022 11:25
@ForestEckhardt ForestEckhardt added the semver:minor A change requiring a minor version bump label Aug 4, 2022
@ForestEckhardt ForestEckhardt merged commit ba6658c into paketo-buildpacks:v2 Aug 4, 2022
@sambhav sambhav deleted the wild-card-stacks branch August 4, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForestEckhardt ForestEckhardt ForestEckhardt approved these changes

@ryanmoran ryanmoran ryanmoran approved these changes

@sophiewigmore sophiewigmore Awaiting requested review from sophiewigmore sophiewigmore is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Add support for wildcard stacks in dependencies
3 participants
@sambhav @ryanmoran @ForestEckhardt