-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Extension config #489
Adding Extension config #489
Conversation
I havent added the MarshalJSON and the UnmarshalJSON as I cant see these methods being used somewhere. If that's not the case, let me know to add them with a further commit :) |
b160984
to
055457f
Compare
This looks good to me. I'd like one more tooling maintainer to take a look and if they're happy with it this can be merged. For posterity: I was initially unsure of the value of creating a separate config, but I do see that some fields are different (e.g. there's the top-level |
Summary
This PR adds the Extension Config structure similar to what is for Buildpack Config structure https://github.com/paketo-buildpacks/packit/blob/v2/cargo/config.go , but for extensions.
Use Cases
With these changes someone can use the extension config to parse and manipulate extension.toml files. For example the developer can use the NewExtensionParser from the cargo repo to create an ExtensionParser, parse an extension.toml file and manipulate it.
Checklist