Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This serves as the initial implementation of RFC 0059, wherein
packit
adopts the accepted Standardized Dependency Metadata format. As part of this implementation changes were made in thecargo
,postal
,scribe
, andsbom
packages to accommodate the new metadata fields. For backwards compatibility, the new fields exist alongside the deprecated fields instead of replacing them entirely.Unresolved Issues:
The standardized format defines a
PURLs
field (i.e. a set of PURLs) instead of just a single PURL for each dependency. This makes sense in theory, but thesyft
library we use to generate SBoMs only allows one PURL per package declaration. To get around this, I thought it appropriate to create asyft
catalog with a package for each unique PURL as opposed to just a single package. However, I have yet to find a suitable method of testing this approach.Though the RFC states: "Note: Both the distros and licenses fields are optional, however if they are given then the non-optional components of them must be set.", I'm not sure what an appropriate place is to enforce that rule (perhaps the parsing logic in
cargo
andpostal
).Resolves #557
Checklist