Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for targets in cargo for extension #623

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Jan 3, 2025

Summary

While jam packages an extension, it recreates the extension.toml. The generated extension.toml is based on what has been parsed from packit. In case some of the variables available on the extension.toml are not available for parsing from the config, will not be included on the generated extension.toml.

This PR adds the targets attribute on the config, similar to this PR for buildpacks #604, to packit be able to output them on the generated extension.toml.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner January 3, 2025 16:30
Copy link

linux-foundation-easycla bot commented Jan 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pacostas / name: Costas Papastathis (23f790c)

@pacostas
Copy link
Contributor Author

pacostas commented Jan 7, 2025

I changed pc and the default git configs were not correct, which is why the CLA was not passing. PR is ready for review @paketo-buildpacks/tooling-maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant