Skip to content

Commit

Permalink
Update test to dynamically pick version from buildpack.toml
Browse files Browse the repository at this point in the history
  • Loading branch information
arjun024 committed May 3, 2021
1 parent b90858e commit 4ca207b
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions integration/layer_reuse_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,7 @@ func testLayerReuse(t *testing.T, context spec.G, it spec.S) {
settings.Buildpacks.Pip.Online,
settings.Buildpacks.BuildPlan.Online,
).
WithEnv(map[string]string{"BP_PIP_VERSION": "21.0.0"}).
// Note: Hard-coded pip version will cause this test to fail once pip 21.0 is
// dropped from the buildpack. Hardcoded here to prevent buildpack from selecting
// latest patch of 21.0 since dependency version has no patch in buildpack.toml.
// Replace WithEnv() above with the one below once pip 21.0 is dropped.
// WithEnv(map[string]string{"BP_PIP_VERSION": buildpackInfo.Metadata.Dependencies[1].Version}).
WithEnv(map[string]string{"BP_PIP_VERSION": buildpackInfo.Metadata.Dependencies[0].Version}).
Execute(name, filepath.Join("testdata", "default_app"))
Expect(err).ToNot(HaveOccurred(), logs.String)

Expand Down

0 comments on commit 4ca207b

Please sign in to comment.