Skip to content

Commit

Permalink
Fix unit tests and update rfc.
Browse files Browse the repository at this point in the history
  • Loading branch information
emily.johnson authored and arjun024 committed May 7, 2021
1 parent 4424aa1 commit 615c0f0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pip_install_process_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func testPipInstallProcess(t *testing.T, context spec.G, it spec.S) {
Expect(err).NotTo(HaveOccurred())

Expect(executable.ExecuteCall.Receives.Execution.Env).To(Equal(append(os.Environ(), fmt.Sprintf("PYTHONUSERBASE=%s", targetLayerPath))))
Expect(executable.ExecuteCall.Receives.Execution.Args).To(Equal([]string{"-m", "pip", "install", srcLayerPath, "--user"}))
Expect(executable.ExecuteCall.Receives.Execution.Args).To(Equal([]string{"-m", "pip", "install", srcLayerPath, "--user", fmt.Sprintf("--find-links=%s", srcLayerPath)}))
})
})

Expand Down
2 changes: 1 addition & 1 deletion rfcs/0001-pip-rearchitecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Download the pip dependency and untar it to a temporary directory (we refer to t
as `<path/to/pip/dependency>` in this RFC).

The buildpack runs `PYTHONUSERBASE=<path/to/pip/layer> python -m pip
install <path/to/pip/dependency> --user` to install the requested version. Setting the
install <path/to/pip/dependency> --user --find-links=<path/to/wheel/and/setuptools>` to install the requested version. Setting the
`PYTHONUSERBASE` variable ensures that pip is installed to the newly created
layer.

Expand Down

0 comments on commit 615c0f0

Please sign in to comment.