Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist pip-source layer; add layer path to PIP_FIND_LINKS env var #451

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

thitch97
Copy link
Contributor

@thitch97 thitch97 commented Aug 10, 2023

Summary

The changes in this PR ensure that we persist the extracted pip source code in a layer which is available to downstream buildpacks at build-time instead of an ephemeral directory so that invocations of pip install may reliably access the packages bundled therein (setuptools, wheel, etc.). Setting the PIP_FIND_LINKS environment variable ensures that the pip-install buildpack can see the location of the pip source without explicit coupling.

Use Cases

Resolves #421

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@thitch97 thitch97 requested a review from a team as a code owner August 10, 2023 19:31
@thitch97 thitch97 added the semver:minor A change requiring a minor version bump label Aug 10, 2023
Copy link
Member

@robdimsdale robdimsdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thank you!

@robdimsdale robdimsdale merged commit e266ccf into main Aug 10, 2023
10 of 11 checks passed
@robdimsdale robdimsdale deleted the persist-src branch August 10, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure we vendor the minimal, sufficient, set of toolchain dependencies for pip applications
2 participants