Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial poc #2

Merged
merged 9 commits into from
Feb 17, 2022
Merged

Initial poc #2

merged 9 commits into from
Feb 17, 2022

Conversation

robdimsdale
Copy link
Member

Summary

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@robdimsdale
Initial functionality
4bf7207 
- No offline functionality as Poetry does not current support vendoring
- Caching may work but is untested
@robdimsdale
Add .github directory.
d948119
@robdimsdale
Fix lint in test.
f024a34
@robdimsdale
Copy link
Member Author

@paketo-buildpacks/python-maintainers this PR also contains the github config which needs to exist before all the checks can pass.

@robdimsdale
Copy link
Member Author

And the integration tests will fail until we publish a poetry buildpack - we can get the integration tests to pass locally by overriding the integration.json config to point to a local tarball. However, we can't do that in CI - we need to publish a poetry buildpack first.

@robdimsdale
Add caching to poetry install process.
41a240c 
- This is the documented way to provide a cache location to
  poetry,though it does not actually speed up the build significantly.
- See python-poetry/poetry#2445 for further
  information about caching in poetry.
@robdimsdale
Remove specific version of poetry buildpack from integration test.
c06fbe8 
- this was required while there was not a published version of the poetry buildpack. We can drop this now that the poetry buildpack has been released.
@robdimsdale
Copy link
Member Author

@paketo-buildpacks/python-maintainers the integration tests are now passing - the only remaining failing checks are the label checks, which will be resolved once the github config is merged as part of this PR.

thitch97
thitch97 reviewed Feb 17, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@robdimsdale @thitch97
Update README.md
1178987 
Co-authored-by: Tim Hitchener <thitch97@users.noreply.github.com>
@thitch97 thitch97 merged commit 3b77866 into main Feb 17, 2022
@thitch97 thitch97 deleted the initial-poc branch February 17, 2022 18:32
@thitch97
Copy link
Contributor

Resolves #1

@thitch97 thitch97 added the semver:minor A change requiring a minor version bump label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thitch97 thitch97 thitch97 approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robdimsdale @thitch97