Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use packit file exists function. #127

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Use packit file exists function. #127

merged 1 commit into from
Mar 29, 2022

Conversation

sophiewigmore
Copy link
Member

Signed-off-by: Sophie Wigmore swigmore@vmware.com

Summary

Noticed this when referencing the code. Let's use the packit version instead and make our lives a little easier.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@robdimsdale
Use packit file exists function.
e89bb6b 
Signed-off-by: Sophie Wigmore <swigmore@vmware.com>
@sophiewigmore sophiewigmore requested a review from a team as a code owner March 29, 2022 19:56
@sophiewigmore sophiewigmore added the semver:patch A change requiring a patch version bump label Mar 29, 2022
@robdimsdale robdimsdale merged commit 465fe81 into main Mar 29, 2022
@robdimsdale robdimsdale deleted the file-exists-refactor branch March 29, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdimsdale robdimsdale robdimsdale approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiewigmore @robdimsdale