Adjust buildplan order #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
force-pushed
the
change-plan-order
branch
from
b063d09 to
77e8c29
Compare
robdimsdale
approved these changes
Oct 20, 2022
This PR adjusts the buildplan order such that the more specific buildplans come first and the least specific comes last. The lifecycle tries buildplans in a specific order and it will stop searching for plans when it hits the first plan where all the provides & requires match up. Having the most specific plans first and least specific plans last ensures that you get a correct match. See [Slack Thread for more details](https://paketobuildpacks.slack.com/archives/CUD6UTCJW/p1666240482044119?thread_ts=1665373426.739299&cid=CUD6UTCJW) Signed-off-by: Daniel Mikusa <dan@mikusa.com>
robdimsdale
force-pushed
the
change-plan-order
branch
from
77e8c29 to
8e95d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the buildplan order such that the more specific buildplans come first and the least specific comes last.
The lifecycle tries buildplans in a specific order and it will stop searching for plans when it hits the first plan where all the provides & requires match up. Having the most specific plans first and least specific plans last ensures that you get a correct match.
See Slack Thread for more details
Signed-off-by: Daniel Mikusa dan@mikusa.com